Skip to content

linux_like: finish unifying SIGEV_THREAD_ID support - #5375

Merged
tgross35 merged 1 commit into
rust-lang:mainfrom
dybucc:musl-sigev-thread-id
Aug 6, 2026
Merged

linux_like: finish unifying SIGEV_THREAD_ID support#5375
tgross35 merged 1 commit into
rust-lang:mainfrom
dybucc:musl-sigev-thread-id

Conversation

@dybucc

@dybucc dybucc commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Description

Closes #3661 by completing the work there. The purpose of the patchset remains
the same. See the patch message for details.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • Commit messages permalink to headers for added or changed API
  • Placeholder or unstable values like *LAST or *MAX have the standard
    doc comment
  • Tested locally (cargo test -p libc-test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@rustbot

rustbot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in an Android module

cc @maurer

@rustbot rustbot added O-android O-gnu O-linux O-linux-like O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 6, 2026

@tgross35 tgross35 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like we're getting a new CI failure on Haiku due to the deprecation, mind adding a commit fixing that (and any others that come up) since it looks like you're actively working on the repo now?

View changes since this review

@tgross35

tgross35 commented Aug 6, 2026

Copy link
Copy Markdown
Member

Looks like we're getting a new CI failure on Haiku due to the deprecation, mind adding a commit fixing that (and any others that come up) since it looks like you're actively working on the repo now?

No need anymore, I wound up getting this in #5374

@tgross35
tgross35 enabled auto-merge August 6, 2026 10:30
This effectively adds the constant for musl too, as the last platform to
support this symbol.

It has been supported in musl since

  7c71792e ("add support for SIGEV_THREAD_ID timers")

and was released with v1.2.2 in January 2021.

The libc-test build script needed some tweaking to skip the symbol when
building against an older musl.

Also double-checked that the `sigevent` struct is defined in the exact
same way.

Signed-off-by: Christoph Heiss <christoph@c8h4.io>

Co-authored-by: Christoph Heiss <christoph@c8h4.io>
@tgross35
tgross35 force-pushed the musl-sigev-thread-id branch from 70076f5 to c8e3c4f Compare August 6, 2026 10:30
@rustbot

rustbot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tgross35
tgross35 added this pull request to the merge queue Aug 6, 2026
Merged via the queue into rust-lang:main with commit 74e58cc Aug 6, 2026
71 of 81 checks passed
@tgross35 tgross35 mentioned this pull request Sep 4, 2026
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-android O-gnu O-linux O-linux-like O-unix stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants